-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fastapi to 0.65.2 and dependencies #12136
Conversation
They include several security fixes.
Investigating the failed tests... |
1c2ef1c
to
3489225
Compare
Ok, apparently the only breaking change is that now clients that send requests with JSON payload must specify the It looks like we do so in the POST but not in PUT or DELETE (or any other method that may accept body payload) in the |
Can you add a "todo" to the last commit? I guess this hack needs to go away sooner or later. |
Aparentely FastAPI no longer assumes JSON by default.
afe7176
to
6c4314a
Compare
I guess the timeout in the failed test is unrelated since I only added the TODO comments in the last commit. |
Yeah, timeout is unrelated. The preceding tests are uploading datasets but are not waiting until the upload is finished, so the job queues up and doesn't finish within 60 seconds. You can see it in the logs, job 21 is the job we're waiting for, while job 17/18/19/20 are still running |
Most methods that stage datasets already do that anwyway. Might be nice in the future if we could just cancel running jobs at the end of a test and not wait for uploads where not necessary, but this should increase test stability in the short term. Fixes galaxyproject#12136 (comment)
Most methods that stage datasets already do that anwyway. Might be nice in the future if we could just cancel running jobs at the end of a test and not wait for uploads where not necessary, but this should increase test stability in the short term. Fixes galaxyproject#12136 (comment)
This supersedes #12128 and upgrades
fastapi
and also its dependencies as some of them include security fixes:fastapi
from 0.63.0 to 0.65.2 see changes herestarlette
from 0.13.6 to 0.14.2 see changes herepydantic
from 1.7.3 to 1.8.2 see changes hereI tried running
poetry update
but for some reason, in my machine, it keeps running for several hours and seems to be stuck in a loop. In the end, I tried to update the dependencies manually, but maybe someone has more luck/experience withpoetry
to make it work.How to test the changes?
License